Patch: don't teminate the session when it doesn't have proper credentials

YA
Yaacov Akiba Slama
Tue, Sep 20, 2016 7:34 PM

Hello,

When a 401/407 challenge is received after a "BYE" request is sent,
sometimes (for instance in asterisk) the library doesn't have the
required credentials.

So it's not appropriate to terminate the session.

Without the enclosed patch, asterisk cannot answer to the challenge
request because the session is already terminated
(PJSIP_INV_STATE_DISCONNECTED) and the sip trunk doesn't hangup when
needed (see https://issues.asterisk.org/jira/browse/ASTERISK-26363).

Regards,

--yas

Hello, When a 401/407 challenge is received after a "BYE" request is sent, sometimes (for instance in asterisk) the library doesn't have the required credentials. So it's not appropriate to terminate the session. Without the enclosed patch, asterisk cannot answer to the challenge request because the session is already terminated (PJSIP_INV_STATE_DISCONNECTED) and the sip trunk doesn't hangup when needed (see https://issues.asterisk.org/jira/browse/ASTERISK-26363). Regards, --yas
YA
Yaacov Akiba Slama
Fri, Sep 23, 2016 5:01 AM

It seems that the patch didn't apply. Enclosed is an updated version.
--yas

On 20/09/16 22:34, Yaacov Akiba Slama wrote:

Hello,

When a 401/407 challenge is received after a "BYE" request is sent,
sometimes (for instance in asterisk) the library doesn't have the
required credentials.

So it's not appropriate to terminate the session.

Without the enclosed patch, asterisk cannot answer to the challenge
request because the session is already terminated
(PJSIP_INV_STATE_DISCONNECTED) and the sip trunk doesn't hangup when
needed (see https://issues.asterisk.org/jira/browse/ASTERISK-26363).

Regards,

--yas


Visit our blog: http://blog.pjsip.org

pjsip mailing list
pjsip@lists.pjsip.org
http://lists.pjsip.org/mailman/listinfo/pjsip_lists.pjsip.org

It seems that the patch didn't apply. Enclosed is an updated version. --yas On 20/09/16 22:34, Yaacov Akiba Slama wrote: > > Hello, > > When a 401/407 challenge is received after a "BYE" request is sent, > sometimes (for instance in asterisk) the library doesn't have the > required credentials. > > So it's not appropriate to terminate the session. > > Without the enclosed patch, asterisk cannot answer to the challenge > request because the session is already terminated > (PJSIP_INV_STATE_DISCONNECTED) and the sip trunk doesn't hangup when > needed (see https://issues.asterisk.org/jira/browse/ASTERISK-26363). > > Regards, > > --yas > > > > _______________________________________________ > Visit our blog: http://blog.pjsip.org > > pjsip mailing list > pjsip@lists.pjsip.org > http://lists.pjsip.org/mailman/listinfo/pjsip_lists.pjsip.org