Possible bug in pjsua_core.c method pjsua_resolve_stun_servers

IK
Imad Khazali
Thu, Jul 12, 2018 8:19 PM

Hi,

In the file pjsua_core.c method pjsua_resolve_stun_servers the method stun_resolve_add_ref is called at the beginning. But the check Below does not decrement the ref.Looks like a bug:

    if (!wait)
        return PJ_SUCCESS;

Thanks,
Imad

Hi, In the file pjsua_core.c method pjsua_resolve_stun_servers the method stun_resolve_add_ref is called at the beginning. But the check Below does not decrement the ref.Looks like a bug:     if (!wait)         return PJ_SUCCESS; Thanks, Imad
NI
Nanang Izzuddin
Fri, Jul 20, 2018 3:18 AM

Hi Imad,

As the process continues asynchronously, the stun_resolve_dec_ref() pair
will be invoked in the completion, e.g: stun_resolve_complete().

BR,
nanang

On Fri, Jul 13, 2018 at 3:19 AM, Imad Khazali via pjsip <
pjsip@lists.pjsip.org> wrote:

Hi,

In the file pjsua_core.c method pjsua_resolve_stun_servers the method
stun_resolve_add_ref is called at the beginning. But the check Below
does not decrement the ref.Looks like a bug:

 if (!wait)
     return PJ_SUCCESS;

Thanks,
Imad


Visit our blog: http://blog.pjsip.org

pjsip mailing list
pjsip@lists.pjsip.org
http://lists.pjsip.org/mailman/listinfo/pjsip_lists.pjsip.org

Hi Imad, As the process continues asynchronously, the stun_resolve_dec_ref() pair will be invoked in the completion, e.g: stun_resolve_complete(). BR, nanang On Fri, Jul 13, 2018 at 3:19 AM, Imad Khazali via pjsip < pjsip@lists.pjsip.org> wrote: > Hi, > > In the file *pjsua_core.c* method *pjsua_resolve_stun_servers* the method > *stun_resolve_add_ref* is called at the beginning. But the check Below > does not decrement the ref.Looks like a bug: > > if (!wait) > return PJ_SUCCESS; > > > Thanks, > Imad > > _______________________________________________ > Visit our blog: http://blog.pjsip.org > > pjsip mailing list > pjsip@lists.pjsip.org > http://lists.pjsip.org/mailman/listinfo/pjsip_lists.pjsip.org > >