Bug in pjmedia/stream.c

Вячеслав Ямонт
Fri, Mar 30, 2018 10:13 AM

Hello all,
I think I found a bug.
In pjmedia/stream.c in function pjmedia_stream_get_dtmf() on line 2851:
pj_assert(sizeof(stream->rx_dtmf_buf[0]) == 0);

I think this should be:
pj_assert(sizeof(stream->rx_dtmf_buf[0]));

Regards,
Vyacheslav Yamont.

Hello all, I think I found a bug. In pjmedia/stream.c in function pjmedia_stream_get_dtmf() on line 2851: pj_assert(sizeof(stream->rx_dtmf_buf[0]) == 0); I think this should be: pj_assert(sizeof(stream->rx_dtmf_buf[0])); Regards, Vyacheslav Yamont.
M
Ming
Mon, Apr 2, 2018 5:04 AM

Hi Vyacheslav,

Thanks for the report. We decided to remove the assertion instead in r5764 (
https://trac.pjsip.org/repos/changeset/5764).

Regards,
Ming

On Fri, Mar 30, 2018 at 6:13 PM, Вячеслав Ямонт yamontv@gmail.com wrote:

Hello all,
I think I found a bug.
In pjmedia/stream.c in function pjmedia_stream_get_dtmf() on line 2851:
pj_assert(sizeof(stream->rx_dtmf_buf[0]) == 0);

I think this should be:
pj_assert(sizeof(stream->rx_dtmf_buf[0]));

Regards,
Vyacheslav Yamont.


Visit our blog: http://blog.pjsip.org

pjsip mailing list
pjsip@lists.pjsip.org
http://lists.pjsip.org/mailman/listinfo/pjsip_lists.pjsip.org

Hi Vyacheslav, Thanks for the report. We decided to remove the assertion instead in r5764 ( https://trac.pjsip.org/repos/changeset/5764). Regards, Ming On Fri, Mar 30, 2018 at 6:13 PM, Вячеслав Ямонт <yamontv@gmail.com> wrote: > Hello all, > I think I found a bug. > In pjmedia/stream.c in function pjmedia_stream_get_dtmf() on line 2851: > pj_assert(sizeof(stream->rx_dtmf_buf[0]) == 0); > > I think this should be: > pj_assert(sizeof(stream->rx_dtmf_buf[0])); > > Regards, > Vyacheslav Yamont. > > > > _______________________________________________ > Visit our blog: http://blog.pjsip.org > > pjsip mailing list > pjsip@lists.pjsip.org > http://lists.pjsip.org/mailman/listinfo/pjsip_lists.pjsip.org > >