pjsip missing function pjsip_tsx_get_inv_session(pjsip_transaction *tsx);

AW
Andreas Wehrmann
Tue, Mar 10, 2020 2:07 PM

Hey there,

I found that the function pjsip_tsx_get_inv_session(pjsip_transaction
*tsx); defined in sip_inv.h is defined nowhere.
Looks like somebody forgot it and nobody else ever needed it...
Anyways, here's what's missing from sip_inv.c:

PJ_DEF(pjsip_inv_session*) pjsip_tsx_get_inv_session(pjsip_transaction *tsx)
{
    struct tsx_inv_data *inv_data = (struct tsx_inv_data
*)tsx->mod_data[mod_inv.mod.id];
    return inv_data ? inv_data->inv : NULL;
}

Best Regards,
Andreas

Hey there, I found that the function pjsip_tsx_get_inv_session(pjsip_transaction *tsx); defined in sip_inv.h is defined nowhere. Looks like somebody forgot it and nobody else ever needed it... Anyways, here's what's missing from sip_inv.c: PJ_DEF(pjsip_inv_session*) pjsip_tsx_get_inv_session(pjsip_transaction *tsx) {     struct tsx_inv_data *inv_data = (struct tsx_inv_data *)tsx->mod_data[mod_inv.mod.id];     return inv_data ? inv_data->inv : NULL; } Best Regards, Andreas
AW
Andreas Wehrmann
Tue, Mar 10, 2020 2:12 PM

On 10.03.20 15:07, Andreas Wehrmann wrote:

Hey there,

I found that the function pjsip_tsx_get_inv_session(pjsip_transaction
*tsx); defined in sip_inv.h is defined nowhere.
Looks like somebody forgot it and nobody else ever needed it...
Anyways, here's what's missing from sip_inv.c:

PJ_DEF(pjsip_inv_session*) pjsip_tsx_get_inv_session(pjsip_transaction
*tsx)
{
    struct tsx_inv_data *inv_data = (struct tsx_inv_data
*)tsx->mod_data[mod_inv.mod.id];
    return inv_data ? inv_data->inv : NULL;
}

Best Regards,
Andreas

And of course I meant "declared in... defined nowhere."

On 10.03.20 15:07, Andreas Wehrmann wrote: > Hey there, > > I found that the function pjsip_tsx_get_inv_session(pjsip_transaction > *tsx); defined in sip_inv.h is defined nowhere. > Looks like somebody forgot it and nobody else ever needed it... > Anyways, here's what's missing from sip_inv.c: > > PJ_DEF(pjsip_inv_session*) pjsip_tsx_get_inv_session(pjsip_transaction > *tsx) > { >     struct tsx_inv_data *inv_data = (struct tsx_inv_data > *)tsx->mod_data[mod_inv.mod.id]; >     return inv_data ? inv_data->inv : NULL; > } > > Best Regards, > Andreas > And of course I meant "declared in... defined nowhere."