missing end of pack pragma in pcap.c

SG
Sandra Gilge (ADATIS)
Sat, Mar 19, 2016 8:46 AM

Hallo,

I'm currently porting PJSIP for Blackfin with VDK.

I think there is an end of #pragma pack() missing in pcap.c
The struct pj_pcap_file should on my opinion not be packed.
This leads to warnings because of potentially misaligned access:
warning: taking the address of a misaligned field is not recommended
status = pj_file_open(pool, path, PJ_O_RDONLY, &file->fd);
Luckily it is not really misaligned. But I think pj_pcap_file is not
needed to be packed.

Best regards,
Sandra

Hallo, I'm currently porting PJSIP for Blackfin with VDK. I think there is an end of #pragma pack() missing in pcap.c The struct pj_pcap_file should on my opinion not be packed. This leads to warnings because of potentially misaligned access: warning: taking the address of a misaligned field is not recommended status = pj_file_open(pool, path, PJ_O_RDONLY, &file->fd); Luckily it is not really misaligned. But I think pj_pcap_file is not needed to be packed. Best regards, Sandra