Empathy List Archives

JK

Jörg Knobloch

Wed, Aug 23, 2017 9:35 PM

As the subject says:

Orange builds causing DXR and Searchfox indexing failures. That was
pointed out to me by :billm on IRC. They're about to switch off indexing
for comm-central, since it causes problems with indexing mozilla-central.

Not having good indexing is hampering development.

Jörg.

As the subject says: Orange builds causing DXR and Searchfox indexing failures. That was pointed out to me by :billm on IRC. They're about to switch off indexing for comm-central, since it causes problems with indexing mozilla-central. Not having good indexing is hampering development. Jörg.

RK

R Kent James

Wed, Aug 23, 2017 9:54 PM

I've proposed this before, and never got any traction with it, but there
is no reason we have to have perma-orange builds. We could disable
failing tests and use BMO to track fixes. This is our choice.

In addition to the DXR issues, the other problem with perma oranges is
that it really discourages people from running tests on their own
patches, as they have to figure out which failures are real.

:rkent

On 8/23/2017 2:35 PM, Jörg Knobloch wrote:

As the subject says:

Orange builds causing DXR and Searchfox indexing failures. That was
pointed out to me by :billm on IRC. They're about to switch off
indexing for comm-central, since it causes problems with indexing
mozilla-central.

Not having good indexing is hampering development.

Jörg.

Maildev mailing list
Maildev@lists.thunderbird.net
http://lists.thunderbird.net/mailman/listinfo/maildev_lists.thunderbird.net

I've proposed this before, and never got any traction with it, but there is no reason we have to have perma-orange builds. We could disable failing tests and use BMO to track fixes. This is our choice. In addition to the DXR issues, the other problem with perma oranges is that it really discourages people from running tests on their own patches, as they have to figure out which failures are real. :rkent On 8/23/2017 2:35 PM, Jörg Knobloch wrote: > As the subject says: > > Orange builds causing DXR and Searchfox indexing failures. That was > pointed out to me by :billm on IRC. They're about to switch off > indexing for comm-central, since it causes problems with indexing > mozilla-central. > > Not having good indexing is hampering development. > > Jörg. > > > _______________________________________________ > Maildev mailing list > Maildev@lists.thunderbird.net > http://lists.thunderbird.net/mailman/listinfo/maildev_lists.thunderbird.net >

JK

Jörg Knobloch

Wed, Aug 23, 2017 10:07 PM

On 23/08/2017 23:54, R Kent James wrote:

I've proposed this before, and never got any traction with it, but
there is no reason we have to have perma-orange builds. We could
disable failing tests and use BMO to track fixes. This is our choice.

In addition to the DXR issues, the other problem with perma oranges is
that it really discourages people from running tests on their own
patches, as they have to figure out which failures are real.

You're confusing orange builds and orange tests.

I'm taking care of orange tests and on Windows and Mac these tests are
green, not so on Linux. At times I disable a test.

Here we're talking about orange builds and unless it's something
simple, like keeping files in sync, it needs a build engineer to look
at. The changeset that initially caused the oranges was:

https://hg.mozilla.org/mozilla-central/rev/1f1dd3ab877d9733604aee3a2bcb66eccf70eb9e#l4.12

If you know what to switch off there, you know more than me. I could add
that line as an experiment to sync the files and see what happens.

Another issue for the build engineer to fix is that Daily updates are
failing.

Jörg.

On 23/08/2017 23:54, R Kent James wrote: > I've proposed this before, and never got any traction with it, but > there is no reason we have to have perma-orange builds. We could > disable failing tests and use BMO to track fixes. This is our choice. > > In addition to the DXR issues, the other problem with perma oranges is > that it really discourages people from running tests on their own > patches, as they have to figure out which failures are real. You're confusing orange builds and orange tests. I'm taking care of orange tests and on Windows and Mac these tests are green, not so on Linux. At times I disable a test. Here we're talking about orange *builds* and unless it's something simple, like keeping files in sync, it needs a build engineer to look at. The changeset that initially caused the oranges was: https://hg.mozilla.org/mozilla-central/rev/1f1dd3ab877d9733604aee3a2bcb66eccf70eb9e#l4.12 If you know what to switch off there, you know more than me. I could add that line as an experiment to sync the files and see what happens. Another issue for the build engineer to fix is that Daily updates are failing. Jörg.

JC

Joshua Cranmer 🐧

Thu, Aug 24, 2017 2:03 PM

On 8/23/2017 4:35 PM, Jörg Knobloch wrote:

As the subject says:

Orange builds causing DXR and Searchfox indexing failures. That was
pointed out to me by :billm on IRC. They're about to switch off
indexing for comm-central, since it causes problems with indexing
mozilla-central.

A few years ago, I took the time to more or less rip out the build
system in comm-central, replacing most of it with the mozilla-central
build system, and then modified the m-c build system to greatly reduce
the likelihood that they will break us (basically, according to
mozbuild, we have two topsrcdirs but they flatten into one topobjdir).
There's rather little that is likely to change in the build system
itself that is likely to break us.

The real problem we have, and have had for years, is automation. Orange
build failures are indication of automation divergence. Tooltool
manifests are duplicated in comm-central largely because the manifests
are needed before the automation runs the build (it's a build step that
clones mozilla-central). The build/ directory is duplicated largely
because we still have two topsrcdirs, but there is the lesser issue that
the automation steps for Thunderbird have diverged from Firefox in the
past. The only real way to fix these build failures for good are to fix
our automation systems to not require duplication that requires keeping
these files in sync.

--
Joshua Cranmer
Thunderbird and DXR developer
Source code archæologist

On 8/23/2017 4:35 PM, Jörg Knobloch wrote: > As the subject says: > > Orange builds causing DXR and Searchfox indexing failures. That was > pointed out to me by :billm on IRC. They're about to switch off > indexing for comm-central, since it causes problems with indexing > mozilla-central. A few years ago, I took the time to more or less rip out the build system in comm-central, replacing most of it with the mozilla-central build system, and then modified the m-c build system to greatly reduce the likelihood that they will break us (basically, according to mozbuild, we have two topsrcdirs but they flatten into one topobjdir). There's rather little that is likely to change in the build system itself that is likely to break us. The real problem we have, and have had for years, is automation. Orange build failures are indication of automation divergence. Tooltool manifests are duplicated in comm-central largely because the manifests are needed before the automation runs the build (it's a build step that clones mozilla-central). The build/ directory is duplicated largely because we still have two topsrcdirs, but there is the lesser issue that the automation steps for Thunderbird have diverged from Firefox in the past. The only real way to fix these build failures for good are to fix our automation systems to not require duplication that requires keeping these files in sync. -- Joshua Cranmer Thunderbird and DXR developer Source code archæologist

maildev@lists.thunderbird.net

Orange builds causing DXR and Searchfox indexing failures