Conferencer bugfix and improvement (with patch)

MS
Michael Scheiffler
Tue, Sep 11, 2018 8:49 AM

Hi there,

I fixed a bug in the conferencer:

The code for writing to the outputs first checks, if the port is muted
or doesn't have any transmitters to it. In that case, an empty frame
is written. The case that the port is disabled is checked afterwards.
This causes dead code since a disabled output port usually doesn't
have any transmitters.
I reordered the code to first check if the output port is disabled. In
that case the port will not be written.

Further, I took function pjmedia_conf_remove_port() and extracted its
content into the functions pjmedia_conf_disconnect_port_from_sources()
and pjmedia_conf_disconnect_port_from_sinks(). This allows the removal
of all connections from or to a given port.

Please integrate.
Thanks a lot in advance.

Regards,
Michael

Hi there, I fixed a bug in the conferencer: The code for writing to the outputs first checks, if the port is muted or doesn't have any transmitters to it. In that case, an empty frame is written. The case that the port is disabled is checked afterwards. This causes dead code since a disabled output port usually doesn't have any transmitters. I reordered the code to first check if the output port is disabled. In that case the port will not be written. Further, I took function pjmedia_conf_remove_port() and extracted its content into the functions pjmedia_conf_disconnect_port_from_sources() and pjmedia_conf_disconnect_port_from_sinks(). This allows the removal of all connections from or to a given port. Please integrate. Thanks a lot in advance. Regards, Michael