Empathy List Archives

JK

Jörg Knobloch

Thu, Sep 21, 2017 11:16 AM

Hello Patrick,

please note that C-C is in a terrible state despite my best efforts:

Apart from failing tests on Linux and broken Mac builds, TB is also pretty much broken which you can see in the orange X and Z. I haven't tried Daily, which is being compiled at time of writing, but from the facts laid out below, it will be unusable.

Last night https://bugzilla.mozilla.org/show_bug.cgi?id=1388789 landed on M-C, which is pretty much a re-write of nsTextFormatter.

I ported what needed to be done in bug https://bugzilla.mozilla.org/show_bug.cgi?id=1399627, but it turned out that the nsTextFormatter::ssprintf(), which we use to print all sorts of sizes, appears to be broken.

I'm tracking that in https://bugzilla.mozilla.org/show_bug.cgi?id=1401821.

So once you've done the merges, C-B will look just as bad, with additional orange B's.

Jörg.

WM

Wayne Mery

Thu, Sep 21, 2017 12:16 PM

On 9/21/2017 7:16 AM, Jörg Knobloch wrote:

Hello Patrick,

please note that C-C is in a terrible state despite my best efforts:

Apart from failing tests on Linux and broken Mac builds, TB is also
pretty much broken which you can see in the orange X and Z. I haven't
tried Daily, which is being compiled at time of writing, but from the
facts laid out below, it will be unusable.

Last night https://bugzilla.mozilla.org/show_bug.cgi?id=1388789 landed
on M-C, which is pretty much a re-write of nsTextFormatter.

I ported what needed to be done in bug
https://bugzilla.mozilla.org/show_bug.cgi?id=1399627, but it turned
out that the nsTextFormatter::ssprintf(), which we use to print all
sorts of sizes, appears to be broken.

I'm tracking that in https://bugzilla.mozilla.org/show_bug.cgi?id=1401821.

So once you've done the merges, C-B will look just as bad, with
additional orange B's.

Jörg.

We're not required to do merge today, right?

Seems to me it would make sense to not merge until the tree is green.

On 9/21/2017 7:16 AM, Jörg Knobloch wrote: > > Hello Patrick, > > please note that C-C is in a terrible state despite my best efforts: > > > Apart from failing tests on Linux and broken Mac builds, TB is also > pretty much broken which you can see in the orange X and Z. I haven't > tried Daily, which is being compiled at time of writing, but from the > facts laid out below, it will be unusable. > > Last night https://bugzilla.mozilla.org/show_bug.cgi?id=1388789 landed > on M-C, which is pretty much a re-write of nsTextFormatter. > > I ported what needed to be done in bug > https://bugzilla.mozilla.org/show_bug.cgi?id=1399627, but it turned > out that the nsTextFormatter::ssprintf(), which we use to print all > sorts of sizes, appears to be broken. > > I'm tracking that in https://bugzilla.mozilla.org/show_bug.cgi?id=1401821. > > So once you've done the merges, C-B will look just as bad, with > additional orange B's. > > Jörg. > We're not required to do merge today, right? Seems to me it would make sense to not merge until the tree is green.

PK

Philipp Kewisch

Thu, Sep 21, 2017 12:32 PM

On 9/21/17 2:16 PM, Wayne Mery wrote:

Seems to me it would make sense to not merge until the tree is green.

Which may mean we'd not merge in the near future. We can still do betas
from older changesets, but m-b will merge, so if we don't then we'd have
to do some strange split. It is very unfortunate, but I don't quite see
the upside in not merging other than the outside impression.

We definitely need all hands on deck to fix this. I hope to spend some
time with the calendar issues this week and will help out in other areas
as much as I can. I hope that others reading this list can help us out a
bit as well :)

Thanks!
Philipp

On 9/21/17 2:16 PM, Wayne Mery wrote: > Seems to me it would make sense to not merge until the tree is green. Which may mean we'd not merge in the near future. We can still do betas from older changesets, but m-b will merge, so if we don't then we'd have to do some strange split. It is very unfortunate, but I don't quite see the upside in not merging other than the outside impression. We definitely need all hands on deck to fix this. I hope to spend some time with the calendar issues this week and will help out in other areas as much as I can. I hope that others reading this list can help us out a bit as well :) Thanks! Philipp

JK

Jörg Knobloch

Fri, Sep 22, 2017 11:47 AM

On 21/09/2017 14:16, Wayne Mery wrote:

Seems to me it would make sense to not merge until the tree is green.

We're moving towards green with Tom working again. He fixed the Linux
tests. M-C fixed the nsTextFormatter issues.

We should do the beta merge today and then uplift anything we do to make
it greener.

Jörg.

On 21/09/2017 14:16, Wayne Mery wrote: > Seems to me it would make sense to not merge until the tree is green. We're moving towards green with Tom working again. He fixed the Linux tests. M-C fixed the nsTextFormatter issues. We should do the beta merge today and then uplift anything we do to make it greener. Jörg.

JK

Jörg Knobloch

Fri, Sep 22, 2017 1:35 PM

On 22/09/2017 13:47, Jörg Knobloch wrote:

We should do the beta merge today and then uplift anything we do to
make it greener.

Actually, we must do this to move to TB 58, otherwise we get into a big
mess.

Jörg.

On 22/09/2017 13:47, Jörg Knobloch wrote: > We should do the beta merge today and then uplift anything we do to > make it greener. Actually, we must do this to move to TB 58, otherwise we get into a big mess. Jörg.

JK

Jörg Knobloch

Fri, Sep 22, 2017 1:52 PM

On 22/09/2017 15:35, Jörg Knobloch wrote:

Actually, we must do this to move to TB 58, otherwise we get into a
big mess.

Already causing test failures since the TB version doesn't match the
M-C/version:

The version of the xul.dll module (58.0.0.6474) is correct (it starts
with '57.0'). - false == true [log…]

Jörg.

On 22/09/2017 15:35, Jörg Knobloch wrote: > Actually, we must do this to move to TB 58, otherwise we get into a > big mess. Already causing test failures since the TB version doesn't match the M-C/version: The version of the xul.dll module (58.0.0.6474) is correct (it starts with '57.0'). - false == true [log…] Jörg.

maildev@lists.thunderbird.net

State of the tree on Merge Day