Hi there, when using the newly added feature for adjusting the output volume of ALSA devices (see https://trac.pjsip.org/repos/ticket/1991), I noticed a couple of problems: a) The very first mixer is used always. Even if it is the wrong card! The master mixer must be managed in a card specific manner. b) The output_vol parameter is not used when calling open_playback() and the capability is set. c) The output volume capability is not reported to via the alsa_factory_get_dev_info() function. The attached patch fixes all of the mentioned problems and includes some small other improvements (e.g. parameter checks, removal of some unused macros). Please integrate. Thank a lot in advance. Regrads, Michael

Just one more small thing: There's one occurrence of 'card->mixer_name' in a TRACE macro of my patch. That needs to be renamed to 'card->pb_mixer_name' in order that the compilation works fine with tracing enabled. Regards, Michael On 10 September 2018 at 11:37, Michael Scheiffler <michael@scheiffler.at> wrote: > Hi there, > > when using the newly added feature for adjusting the output volume of > ALSA devices (see https://trac.pjsip.org/repos/ticket/1991), I noticed > a couple of problems: > a) The very first mixer is used always. Even if it is the wrong card! > The master mixer must be managed in a card specific manner. > b) The output_vol parameter is not used when calling open_playback() > and the capability is set. > c) The output volume capability is not reported to via the > alsa_factory_get_dev_info() function. > > The attached patch fixes all of the mentioned problems and includes > some small other improvements (e.g. parameter checks, removal of some > unused macros). > > > Please integrate. Thank a lot in advance. > > > Regrads, > Michael