Declared, yet undefined func: pjmedia_null_video_factory() v2.8

CE
Cameron Elliott
Fri, Nov 2, 2018 9:22 PM

Sorry for the duplicate posts yesterday, short story: I made a mistake.

My question relates to v2.8

Anyway, on my journey to understand and work with Pjsip video, I made an
interesting discovery.
I am looking for a sample nop/null video sink,
and I came across these lines of code in ...\pjmedia-videodev\videodev.c

/* extern functions to create factories */

#if PJMEDIA_VIDEO_DEV_HAS_NULL_VIDEO
pjmedia_vid_dev_factory* pjmedia_null_video_factory(pj_pool_factory *pf);
#endif

Interestingly, while the function is declared, it is not defined,nor used
anywhere.
[I searched the full git repo. and release 2.4.5]

I am wondering, does anyone know where I can find the body of this method?
Also, does anyone know if this implements a null sink, or null source?
[if source, then I know colorbar is not too far off, but if it is a sink,
it seems a much easier place to start then one of: sdl_dev.c, dshow_dev.c,
or android_opengl.c

Thank you,
Cameron

Sorry for the duplicate posts yesterday, short story: I made a mistake. My question relates to v2.8 Anyway, on my journey to understand and work with Pjsip video, I made an interesting discovery. I am looking for a sample nop/null video sink, and I came across these lines of code in ...\pjmedia-videodev\videodev.c /* extern functions to create factories */ > #if PJMEDIA_VIDEO_DEV_HAS_NULL_VIDEO > pjmedia_vid_dev_factory* pjmedia_null_video_factory(pj_pool_factory *pf); > #endif Interestingly, while the function is declared, it is not defined,nor used anywhere. [I searched the full git repo. and release 2.4.5] I am wondering, does anyone know where I can find the body of this method? Also, does anyone know if this implements a null sink, or null source? [if source, then I know colorbar is not too far off, but if it is a sink, it seems a much easier place to start then one of: sdl_dev.c, dshow_dev.c, or android_opengl.c Thank you, Cameron
M
Ming
Mon, Nov 5, 2018 12:49 AM

Hi Cameron,

Thanks for noticing it. It was never implemented indeed. I removed it
in r5902 (https://trac.pjsip.org/repos/changeset/5902).

Regards,
Ming

On Sat, Nov 3, 2018 at 5:22 AM, Cameron Elliott
cameron@cameronelliott.com wrote:

Sorry for the duplicate posts yesterday, short story: I made a mistake.

My question relates to v2.8

Anyway, on my journey to understand and work with Pjsip video, I made an
interesting discovery.
I am looking for a sample nop/null video sink,
and I came across these lines of code in ...\pjmedia-videodev\videodev.c

/* extern functions to create factories /
#if PJMEDIA_VIDEO_DEV_HAS_NULL_VIDEO
pjmedia_vid_dev_factory
pjmedia_null_video_factory(pj_pool_factory *pf);
#endif

Interestingly, while the function is declared, it is not defined,nor used
anywhere.
[I searched the full git repo. and release 2.4.5]

I am wondering, does anyone know where I can find the body of this method?
Also, does anyone know if this implements a null sink, or null source?
[if source, then I know colorbar is not too far off, but if it is a sink,
it seems a much easier place to start then one of: sdl_dev.c, dshow_dev.c,
or android_opengl.c

Thank you,
Cameron


Visit our blog: http://blog.pjsip.org

pjsip mailing list
pjsip@lists.pjsip.org
http://lists.pjsip.org/mailman/listinfo/pjsip_lists.pjsip.org

Hi Cameron, Thanks for noticing it. It was never implemented indeed. I removed it in r5902 (https://trac.pjsip.org/repos/changeset/5902). Regards, Ming On Sat, Nov 3, 2018 at 5:22 AM, Cameron Elliott <cameron@cameronelliott.com> wrote: > Sorry for the duplicate posts yesterday, short story: I made a mistake. > > My question relates to v2.8 > > Anyway, on my journey to understand and work with Pjsip video, I made an > interesting discovery. > I am looking for a sample nop/null video sink, > and I came across these lines of code in ...\pjmedia-videodev\videodev.c > >> /* extern functions to create factories */ >> #if PJMEDIA_VIDEO_DEV_HAS_NULL_VIDEO >> pjmedia_vid_dev_factory* pjmedia_null_video_factory(pj_pool_factory *pf); >> #endif > > > Interestingly, while the function is declared, it is not defined,nor used > anywhere. > [I searched the full git repo. and release 2.4.5] > > I am wondering, does anyone know where I can find the body of this method? > Also, does anyone know if this implements a null sink, or null source? > [if source, then I know colorbar is not too far off, but if it is a sink, > it seems a much easier place to start then one of: sdl_dev.c, dshow_dev.c, > or android_opengl.c > > Thank you, > Cameron > > > > > _______________________________________________ > Visit our blog: http://blog.pjsip.org > > pjsip mailing list > pjsip@lists.pjsip.org > http://lists.pjsip.org/mailman/listinfo/pjsip_lists.pjsip.org >