Hi, a severe bug was recently opened in Debian (https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=877364) which threatens pjproject to be removed due to licensing issues (as you may know, Debian is very strict regarding correct licenses). pjproject as a whole is GPLv2+. However, there are two functions in pjlib/src/pj/sock_linux_kernel.c that have apparently been taken from BSD, and are BSD 4-Clause licensed. This license is incompatible with GPL. https://www.gnu.org/licenses/license-list.html.en#OriginalBSD https://www.gnu.org/licenses/bsd.html /* * Permission to steal inet_ntoa() and inet_aton() as long as this notice below * is included: */ /* As far as I understand this these are pretty much standard functions. I think the best solution would be to copy them from a GPLv2+ source and drop the BSD 4-clause license. But I'm far from being a license expert. Bernhard

static char b[18];

static __thread char buffer[18];

Hi, Looking at the pjlib/src/pj/sock_linux_kernel.c implementation of pj_inet_ntoa(), it doesn’t appear to be thread-safe either!! It uses a static char array: static char b[18]; The glibc workaround for this is to use a static char array per thread: static __thread char buffer[18]; Note - inet_ntoa() is now considered to be deprecated in favour of inet_ntop() - which uses a user supplied char array, is thread-safe, and handles IPV4 and IPV6 addresses [inet_ntoa() is IPV4 only]. Regards, Ian > On 12 Oct 2017, at 09:02, Bernhard Schmidt <berni@birkenwald.de> wrote: > > Hi, > > a severe bug was recently opened in Debian > (https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=877364) which > threatens pjproject to be removed due to licensing issues (as you may > know, Debian is very strict regarding correct licenses). > > pjproject as a whole is GPLv2+. However, there are two functions in > pjlib/src/pj/sock_linux_kernel.c that have apparently been taken from > BSD, and are BSD 4-Clause licensed. This license is incompatible with GPL. > > https://www.gnu.org/licenses/license-list.html.en#OriginalBSD > https://www.gnu.org/licenses/bsd.html > > /* > * Permission to steal inet_ntoa() and inet_aton() as long as this > notice below > * is included: > */ > /* > > As far as I understand this these are pretty much standard functions. I > think the best solution would be to copy them from a GPLv2+ source and > drop the BSD 4-clause license. But I'm far from being a license expert. > > Bernhard > > _______________________________________________ > Visit our blog: http://blog.pjsip.org > > pjsip mailing list > pjsip@lists.pjsip.org > http://lists.pjsip.org/mailman/listinfo/pjsip_lists.pjsip.org

Hi, I wonder what is the status of this issue? Bernhard Schmidt <berni@birkenwald.de> writes: > Hi, > > a severe bug was recently opened in Debian > (https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=877364) which > threatens pjproject to be removed due to licensing issues (as you may > know, Debian is very strict regarding correct licenses). > > pjproject as a whole is GPLv2+. However, there are two functions in > pjlib/src/pj/sock_linux_kernel.c that have apparently been taken from > BSD, and are BSD 4-Clause licensed. This license is incompatible with GPL. > > https://www.gnu.org/licenses/license-list.html.en#OriginalBSD > https://www.gnu.org/licenses/bsd.html > > /* > * Permission to steal inet_ntoa() and inet_aton() as long as this > notice below > * is included: > */ > /* > > As far as I understand this these are pretty much standard functions. I > think the best solution would be to copy them from a GPLv2+ source and > drop the BSD 4-clause license. But I'm far from being a license expert. > > Bernhard > > _______________________________________________ > Visit our blog: http://blog.pjsip.org > > pjsip mailing list > pjsip@lists.pjsip.org > http://lists.pjsip.org/mailman/listinfo/pjsip_lists.pjsip.org > -- - https://libreplanet.org/wiki/User:Adfeno - Palestrante e consultor sobre /software/ livre (não confundir com gratis). - "WhatsApp"? Ele não é livre. Por favor, veja formas de se comunicar instantaneamente comigo no endereço abaixo. - Contato: https://libreplanet.org/wiki/User:Adfeno#vCard - Arquivos comuns aceitos (apenas sem DRM): Corel Draw, Microsoft Office, MP3, MP4, WMA, WMV. - Arquivos comuns aceitos e enviados: CSV, GNU Dia, GNU Emacs Org, GNU GIMP, Inkscape SVG, JPG, LibreOffice (padrão ODF), OGG, OPUS, PDF (apenas sem DRM), PNG, TXT, WEBM.

Hi all, sock_linux_kernel (and *linux_kernel*) has been deprecated for quite some time (years ago) and hasn't been used in our core code base. Regards, Ming On Fri, Nov 10, 2017 at 7:09 PM, Adonay Felipe Nogueira < adfeno@hyperbola.info> wrote: > Hi, I wonder what is the status of this issue? > > Bernhard Schmidt <berni@birkenwald.de> writes: > > > Hi, > > > > a severe bug was recently opened in Debian > > (https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=877364) which > > threatens pjproject to be removed due to licensing issues (as you may > > know, Debian is very strict regarding correct licenses). > > > > pjproject as a whole is GPLv2+. However, there are two functions in > > pjlib/src/pj/sock_linux_kernel.c that have apparently been taken from > > BSD, and are BSD 4-Clause licensed. This license is incompatible with > GPL. > > > > https://www.gnu.org/licenses/license-list.html.en#OriginalBSD > > https://www.gnu.org/licenses/bsd.html > > > > /* > > * Permission to steal inet_ntoa() and inet_aton() as long as this > > notice below > > * is included: > > */ > > /* > > > > As far as I understand this these are pretty much standard functions. I > > think the best solution would be to copy them from a GPLv2+ source and > > drop the BSD 4-clause license. But I'm far from being a license expert. > > > > Bernhard > > > > _______________________________________________ > > Visit our blog: http://blog.pjsip.org > > > > pjsip mailing list > > pjsip@lists.pjsip.org > > http://lists.pjsip.org/mailman/listinfo/pjsip_lists.pjsip.org > > > > -- > - https://libreplanet.org/wiki/User:Adfeno > - Palestrante e consultor sobre /software/ livre (não confundir com > gratis). > - "WhatsApp"? Ele não é livre. Por favor, veja formas de se comunicar > instantaneamente comigo no endereço abaixo. > - Contato: https://libreplanet.org/wiki/User:Adfeno#vCard > - Arquivos comuns aceitos (apenas sem DRM): Corel Draw, Microsoft > Office, MP3, MP4, WMA, WMV. > - Arquivos comuns aceitos e enviados: CSV, GNU Dia, GNU Emacs Org, GNU > GIMP, Inkscape SVG, JPG, LibreOffice (padrão ODF), OGG, OPUS, PDF > (apenas sem DRM), PNG, TXT, WEBM. > > _______________________________________________ > Visit our blog: http://blog.pjsip.org > > pjsip mailing list > pjsip@lists.pjsip.org > http://lists.pjsip.org/mailman/listinfo/pjsip_lists.pjsip.org >

Am 10.11.2017 um 12:16 schrieb Ming: > Hi all, > > sock_linux_kernel (and *linux_kernel*) has been deprecated for quite > some time (years ago) and hasn't been used in our core code base. Would it be possible to drop this function and remove the copyright clause then? This would fix all licensing issues I'm aware of. Bernhard

Hi all, I've removed *linux_kernel* in ticket #2062 ( https://trac.pjsip.org/repos/ticket/2062). Regards, Ming On Fri, Nov 10, 2017 at 7:48 PM, Bernhard Schmidt <berni@birkenwald.de> wrote: > Am 10.11.2017 um 12:16 schrieb Ming: > > Hi all, > > > > sock_linux_kernel (and *linux_kernel*) has been deprecated for quite > > some time (years ago) and hasn't been used in our core code base. > > Would it be possible to drop this function and remove the copyright > clause then? This would fix all licensing issues I'm aware of. > > Bernhard > > _______________________________________________ > Visit our blog: http://blog.pjsip.org > > pjsip mailing list > pjsip@lists.pjsip.org > http://lists.pjsip.org/mailman/listinfo/pjsip_lists.pjsip.org >