[PATCH] [RFC] Add pjmedia_stream_get_rtp_sessions() function

BC
b17 c0de
Sat, Oct 29, 2016 12:16 AM

Hi,
I am writing a transport adapter that needs to do some special
handling of the RTP stream. In particular, it needs to both inject RTP
packets into the outgoing stream as well as hide incoming packets from
the media stream. These packets are standard RTP packets with a
special payload type. Since these are normal RTP packets, they are be
sequenced together with the other RTP audio/DTMF packets. To handle
the sequence numbers and timestamps correctly, I really need access to
the RTP session structs of pjmedia_stream. This minimal patch adds a
function that returns the RTP sessions of a pjmedia_stream so that
transports can correctly handle the RTP stream more intelligently.

I welcome feedback on this patch. I really don't see any other way to
do this sensibly from a transport adapter.

Best regards,
Kal

Hi, I am writing a transport adapter that needs to do some special handling of the RTP stream. In particular, it needs to both inject RTP packets into the outgoing stream as well as hide incoming packets from the media stream. These packets are standard RTP packets with a special payload type. Since these are normal RTP packets, they are be sequenced together with the other RTP audio/DTMF packets. To handle the sequence numbers and timestamps correctly, I really need access to the RTP session structs of pjmedia_stream. This minimal patch adds a function that returns the RTP sessions of a pjmedia_stream so that transports can correctly handle the RTP stream more intelligently. I welcome feedback on this patch. I really don't see any other way to do this sensibly from a transport adapter. Best regards, Kal
RS
Riza Sulistyo
Fri, Nov 4, 2016 3:11 PM

Hi Kal,

Thanks for the patch, we have committed it on
https://trac.pjsip.org/repos/ticket/1978 with some modifications.
To prevent accidental modification to the RTP session we have made it as
const, so you might need to cast it.

Best Regards,

Riza

On Sat, Oct 29, 2016 at 7:16 AM, b17 c0de b17c0de@gmail.com wrote:

Hi,
I am writing a transport adapter that needs to do some special
handling of the RTP stream. In particular, it needs to both inject RTP
packets into the outgoing stream as well as hide incoming packets from
the media stream. These packets are standard RTP packets with a
special payload type. Since these are normal RTP packets, they are be
sequenced together with the other RTP audio/DTMF packets. To handle
the sequence numbers and timestamps correctly, I really need access to
the RTP session structs of pjmedia_stream. This minimal patch adds a
function that returns the RTP sessions of a pjmedia_stream so that
transports can correctly handle the RTP stream more intelligently.

I welcome feedback on this patch. I really don't see any other way to
do this sensibly from a transport adapter.

Best regards,
Kal


Visit our blog: http://blog.pjsip.org

pjsip mailing list
pjsip@lists.pjsip.org
http://lists.pjsip.org/mailman/listinfo/pjsip_lists.pjsip.org

Hi Kal, Thanks for the patch, we have committed it on https://trac.pjsip.org/repos/ticket/1978 with some modifications. To prevent accidental modification to the RTP session we have made it as const, so you might need to cast it. Best Regards, Riza On Sat, Oct 29, 2016 at 7:16 AM, b17 c0de <b17c0de@gmail.com> wrote: > Hi, > I am writing a transport adapter that needs to do some special > handling of the RTP stream. In particular, it needs to both inject RTP > packets into the outgoing stream as well as hide incoming packets from > the media stream. These packets are standard RTP packets with a > special payload type. Since these are normal RTP packets, they are be > sequenced together with the other RTP audio/DTMF packets. To handle > the sequence numbers and timestamps correctly, I really need access to > the RTP session structs of pjmedia_stream. This minimal patch adds a > function that returns the RTP sessions of a pjmedia_stream so that > transports can correctly handle the RTP stream more intelligently. > > I welcome feedback on this patch. I really don't see any other way to > do this sensibly from a transport adapter. > > Best regards, > Kal > > _______________________________________________ > Visit our blog: http://blog.pjsip.org > > pjsip mailing list > pjsip@lists.pjsip.org > http://lists.pjsip.org/mailman/listinfo/pjsip_lists.pjsip.org > >