"Allow multiple codecs in SDP answer" feature doesn't work as expected

AE
Alexey Ermoshin
Thu, Mar 15, 2018 9:43 AM

Hello,

I need SDP negotiator to respond with multiple codecs, so I've set
define PJMEDIA_SDP_NEG_ANSWER_MULTIPLE_CODECS 1. But it doesn't help.

Expecting snd_neg.c file I've found that answer_with_multiple_codecs field
of pjmedia_sdp_neg structure is initialized with corresponding define only
in pjmedia_sdp_neg_create_w_local_offer(), but not
in pjmedia_sdp_neg_create_w_remote_offer(), so this feature doesn't work on
creating SDP answer.

I've added the same initialization line into
pjmedia_sdp_neg_create_w_remote_offer()
as in  pjmedia_sdp_neg_create_w_local_offer(), so now I have all supported
codecs in my SDP answer.

I offer a small patch to be included in the next release.


Alexey Ermoshin

Hello, I need SDP negotiator to respond with multiple codecs, so I've set define PJMEDIA_SDP_NEG_ANSWER_MULTIPLE_CODECS 1. But it doesn't help. Expecting snd_neg.c file I've found that answer_with_multiple_codecs field of pjmedia_sdp_neg structure is initialized with corresponding define only in pjmedia_sdp_neg_create_w_local_offer(), but not in pjmedia_sdp_neg_create_w_remote_offer(), so this feature doesn't work on creating SDP answer. I've added the same initialization line into pjmedia_sdp_neg_create_w_remote_offer() as in pjmedia_sdp_neg_create_w_local_offer(), so now I have all supported codecs in my SDP answer. I offer a small patch to be included in the next release. --- Alexey Ermoshin
M
Ming
Fri, Mar 16, 2018 7:55 AM

Hi Alexey,

Thanks for the patch. I committed this in r5756 (
https://trac.pjsip.org/repos/changeset/5756).

Regards,
Ming

On Thu, Mar 15, 2018 at 5:43 PM, Alexey Ermoshin <
alexey.ermoshin.78@gmail.com> wrote:

Hello,

I need SDP negotiator to respond with multiple codecs, so I've set
define PJMEDIA_SDP_NEG_ANSWER_MULTIPLE_CODECS 1. But it doesn't help.

Expecting snd_neg.c file I've found that answer_with_multiple_codecs field
of pjmedia_sdp_neg structure is initialized with corresponding define only
in pjmedia_sdp_neg_create_w_local_offer(), but not
in pjmedia_sdp_neg_create_w_remote_offer(), so this feature doesn't work
on creating SDP answer.

I've added the same initialization line into
pjmedia_sdp_neg_create_w_remote_offer() as in
pjmedia_sdp_neg_create_w_local_offer(), so now I have all supported
codecs in my SDP answer.

I offer a small patch to be included in the next release.


Alexey Ermoshin


Visit our blog: http://blog.pjsip.org

pjsip mailing list
pjsip@lists.pjsip.org
http://lists.pjsip.org/mailman/listinfo/pjsip_lists.pjsip.org

Hi Alexey, Thanks for the patch. I committed this in r5756 ( https://trac.pjsip.org/repos/changeset/5756). Regards, Ming On Thu, Mar 15, 2018 at 5:43 PM, Alexey Ermoshin < alexey.ermoshin.78@gmail.com> wrote: > Hello, > > I need SDP negotiator to respond with multiple codecs, so I've set > define PJMEDIA_SDP_NEG_ANSWER_MULTIPLE_CODECS 1. But it doesn't help. > > Expecting snd_neg.c file I've found that answer_with_multiple_codecs field > of pjmedia_sdp_neg structure is initialized with corresponding define only > in pjmedia_sdp_neg_create_w_local_offer(), but not > in pjmedia_sdp_neg_create_w_remote_offer(), so this feature doesn't work > on creating SDP answer. > > I've added the same initialization line into > pjmedia_sdp_neg_create_w_remote_offer() as in > pjmedia_sdp_neg_create_w_local_offer(), so now I have all supported > codecs in my SDP answer. > > I offer a small patch to be included in the next release. > > --- > Alexey Ermoshin > > _______________________________________________ > Visit our blog: http://blog.pjsip.org > > pjsip mailing list > pjsip@lists.pjsip.org > http://lists.pjsip.org/mailman/listinfo/pjsip_lists.pjsip.org > >