[PATCH] [RFC] Add attach2 to pjmedia transport interface

BC
b17 c0de
Sat, Oct 29, 2016 12:45 PM

Hi,
This patch adds a attach2() member function to pjmedia_transport_op
and the corresponding pjmedia_transport_attach2() function. These new
functions take an additional explicit parameter for the media stream.
This allows all transport adapters in the chain to have access to the
media stream. Currently only the first transport adapter can get
access to the stream by casting the user_data parameter, although this
is also undocumented. This change has been implemented in a way that
allows existing code to continue to work unmodified as before. New
transports should implement attach2() instead of attach().

I look forward to hearing your feedback on this change.

Best Regards,
Kal

Hi, This patch adds a attach2() member function to pjmedia_transport_op and the corresponding pjmedia_transport_attach2() function. These new functions take an additional explicit parameter for the media stream. This allows all transport adapters in the chain to have access to the media stream. Currently only the first transport adapter can get access to the stream by casting the user_data parameter, although this is also undocumented. This change has been implemented in a way that allows existing code to continue to work unmodified as before. New transports should implement attach2() instead of attach(). I look forward to hearing your feedback on this change. Best Regards, Kal
RS
Riza Sulistyo
Fri, Nov 4, 2016 3:06 PM

Hi Kal,

Thanks for your patch, we have committed it on
https://trac.pjsip.org/repos/ticket/1977
with some modifications.

Best Regards,

Riza

On Sat, Oct 29, 2016 at 7:45 PM, b17 c0de b17c0de@gmail.com wrote:

Hi,
This patch adds a attach2() member function to pjmedia_transport_op
and the corresponding pjmedia_transport_attach2() function. These new
functions take an additional explicit parameter for the media stream.
This allows all transport adapters in the chain to have access to the
media stream. Currently only the first transport adapter can get
access to the stream by casting the user_data parameter, although this
is also undocumented. This change has been implemented in a way that
allows existing code to continue to work unmodified as before. New
transports should implement attach2() instead of attach().

I look forward to hearing your feedback on this change.

Best Regards,
Kal


Visit our blog: http://blog.pjsip.org

pjsip mailing list
pjsip@lists.pjsip.org
http://lists.pjsip.org/mailman/listinfo/pjsip_lists.pjsip.org

Hi Kal, Thanks for your patch, we have committed it on https://trac.pjsip.org/repos/ticket/1977 with some modifications. Best Regards, Riza On Sat, Oct 29, 2016 at 7:45 PM, b17 c0de <b17c0de@gmail.com> wrote: > Hi, > This patch adds a attach2() member function to pjmedia_transport_op > and the corresponding pjmedia_transport_attach2() function. These new > functions take an additional explicit parameter for the media stream. > This allows all transport adapters in the chain to have access to the > media stream. Currently only the first transport adapter can get > access to the stream by casting the user_data parameter, although this > is also undocumented. This change has been implemented in a way that > allows existing code to continue to work unmodified as before. New > transports should implement attach2() instead of attach(). > > I look forward to hearing your feedback on this change. > > Best Regards, > Kal > > _______________________________________________ > Visit our blog: http://blog.pjsip.org > > pjsip mailing list > pjsip@lists.pjsip.org > http://lists.pjsip.org/mailman/listinfo/pjsip_lists.pjsip.org > >
BC
b17 c0de
Sun, Nov 6, 2016 6:38 PM

Hi Riza,
Thanks for committing my patch. I like the changes you made to it.

Best Regards,
Kal

On Sat, Nov 5, 2016 at 4:06 AM, Riza Sulistyo riza@pjsip.org wrote:

Hi Kal,

Thanks for your patch, we have committed it on
https://trac.pjsip.org/repos/ticket/1977
with some modifications.

Best Regards,

Riza

On Sat, Oct 29, 2016 at 7:45 PM, b17 c0de b17c0de@gmail.com wrote:

Hi,
This patch adds a attach2() member function to pjmedia_transport_op
and the corresponding pjmedia_transport_attach2() function. These new
functions take an additional explicit parameter for the media stream.
This allows all transport adapters in the chain to have access to the
media stream. Currently only the first transport adapter can get
access to the stream by casting the user_data parameter, although this
is also undocumented. This change has been implemented in a way that
allows existing code to continue to work unmodified as before. New
transports should implement attach2() instead of attach().

I look forward to hearing your feedback on this change.

Best Regards,
Kal


Visit our blog: http://blog.pjsip.org

pjsip mailing list
pjsip@lists.pjsip.org
http://lists.pjsip.org/mailman/listinfo/pjsip_lists.pjsip.org

Hi Riza, Thanks for committing my patch. I like the changes you made to it. Best Regards, Kal On Sat, Nov 5, 2016 at 4:06 AM, Riza Sulistyo <riza@pjsip.org> wrote: > Hi Kal, > > Thanks for your patch, we have committed it on > https://trac.pjsip.org/repos/ticket/1977 > with some modifications. > > Best Regards, > > Riza > > On Sat, Oct 29, 2016 at 7:45 PM, b17 c0de <b17c0de@gmail.com> wrote: >> >> Hi, >> This patch adds a attach2() member function to pjmedia_transport_op >> and the corresponding pjmedia_transport_attach2() function. These new >> functions take an additional explicit parameter for the media stream. >> This allows all transport adapters in the chain to have access to the >> media stream. Currently only the first transport adapter can get >> access to the stream by casting the user_data parameter, although this >> is also undocumented. This change has been implemented in a way that >> allows existing code to continue to work unmodified as before. New >> transports should implement attach2() instead of attach(). >> >> I look forward to hearing your feedback on this change. >> >> Best Regards, >> Kal >> >> _______________________________________________ >> Visit our blog: http://blog.pjsip.org >> >> pjsip mailing list >> pjsip@lists.pjsip.org >> http://lists.pjsip.org/mailman/listinfo/pjsip_lists.pjsip.org >> > > > _______________________________________________ > Visit our blog: http://blog.pjsip.org > > pjsip mailing list > pjsip@lists.pjsip.org > http://lists.pjsip.org/mailman/listinfo/pjsip_lists.pjsip.org >